Take the /CIDToGIDMap data into account when computing the hash, in PartialEvaluator.preEvaluateFont, for composite fonts (bug 1734802)
#14111
Conversation
…PartialEvaluator.preEvaluateFont`, for composite fonts (bug 1734802) This is unfortunately *yet another* bug in the `preEvaluateFont`-implementation, and I've lost count of the number of times I've had to tweak this code over the years :-( I really cannot help thinking that PR 4423 was way too simplistic, since it missed a bunch of cases that leads to broken font rendering in many PDF documents. Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1734802
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b627b93f9fa7740/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/951bac97ff4a740/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b627b93f9fa7740/output.txt Total script time: 23.96 mins
Image differences available at: http://54.241.84.105:8877/b627b93f9fa7740/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/951bac97ff4a740/output.txt Total script time: 41.01 mins
Image differences available at: http://54.193.163.58:8877/951bac97ff4a740/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/bdc47b0d4f3ffac/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/bdc47b0d4f3ffac/output.txt Total script time: 4.26 mins Published |
|
Thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7d0969cfb43dfcd/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/77746c93e359589/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7d0969cfb43dfcd/output.txt Total script time: 20.12 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/77746c93e359589/output.txt Total script time: 29.57 mins
|
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/661d76dfdd726ab/output.txt |
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/661d76dfdd726ab/output.txt Total script time: 37.53 mins
|
This is unfortunately yet another bug in the
preEvaluateFont-implementation, and I've lost count of the number of times I've had to tweak this code over the years :-(I really cannot help thinking that PR #4423 was way too simplistic, since it missed a bunch of cases that leads to broken font rendering in many PDF documents.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1734802