Annotations - Avoid empty value in text field when storage contains something for it (bug 1719148) #14044
Conversation
…omething for it (bug 1719148) - it aims to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1719148; - JS can set a property for a non-rendered annotation using the annotationStorage but the other unset default properties must be used when the annotation is finally rendered; - so this patch just adds the properties already set in the annotationStorage to the default value.
|
/botio unittest |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/8924ea3b85a1a7a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5aeb3d31dfceb7b/output.txt |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/f889a3ae763bd27/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.193.163.58:8877/e8e39d3f0ed89a0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5aeb3d31dfceb7b/output.txt Total script time: 2.76 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f889a3ae763bd27/output.txt Total script time: 3.53 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8924ea3b85a1a7a/output.txt Total script time: 5.91 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/e8e39d3f0ed89a0/output.txt Total script time: 5.52 mins
|
@gijsk shared his pdf with me, I was able to reproduce his issue with a local firefox build and I verified that this patch fixes the issue.