Skip to content

Reduce the size of TextLayerRenderTask._textDivProperties in "regular" text-selection mode #13976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

While these changes will obviously not have a significant effect on overall memory usage, it cannot hurt as far as I'm concerned. This patch makes the following changes:

  • Clear out _textDivProperties once rendering is done, since those properties are only necessary to keep alive when enhanced text-selection is being used.

  • Reduce the size of the _textDivProperties-entries by default, since a majority of the properties are only relevant when enhanced text-selection is being used.

…ar" text-selection mode

While these changes will obviously not have a significant effect on overall memory usage, it cannot hurt as far as I'm concerned. This patch makes the following changes:
 - Clear out `_textDivProperties` once rendering is done, since those properties are only necessary to keep alive when *enhanced* text-selection is being used.

 - Reduce the size of the `_textDivProperties`-entries by default, since a majority of the properties are only relevant when *enhanced* text-selection is being used.
@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2021

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3177f87ec3a4377/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/3177f87ec3a4377/output.txt

Total script time: 4.15 mins

Published

@timvandermeij
Copy link
Contributor

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9f5f2c691201623/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/1ca0f8741942f90/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/9f5f2c691201623/output.txt

Total script time: 21.51 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 9
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/9f5f2c691201623/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 5, 2021

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/1ca0f8741942f90/output.txt

Total script time: 39.66 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/1ca0f8741942f90/reftest-analyzer.html#web=eq.log

@timvandermeij timvandermeij merged commit d95f680 into mozilla:master Sep 5, 2021
@timvandermeij
Copy link
Contributor

Thanks!

@Snuffleupagus Snuffleupagus deleted the _textDivProperties-cleanup branch September 5, 2021 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants