[api-minor] Change {PDFPageView, PDFThumbnailView}.update to take a parameter object
#13973
Conversation
… parameter object The old `update`-signature started to annoy me back when I added optional content support to the viewer, since we're (often) forced to pass in a bunch of arguments that we don't care about whenever these methods are called. This is tagged `api-minor` since `PDFPageView` is being used in the `pageviewer` component example, and it's thus possible that these changes could affect some users; the next commit adds fallback handling for the old format.
Snuffleupagus
changed the title
{PDFPageView, PDFThumbnailView}.update to take a parameter object
…method signature This is done separately from the previous commit, to make it easier to revert these changes in the future.
Snuffleupagus
force-pushed
the
viewer-components-refactor-update
branch
from
033a328 to
8466204
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/30620a028b38fff/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5eadd42a332dbec/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/30620a028b38fff/output.txt Total script time: 3.54 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5eadd42a332dbec/output.txt Total script time: 7.81 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 1 Live output at: http://54.241.84.105:8877/619ffd14696c316/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/619ffd14696c316/output.txt Total script time: 4.22 mins Published |
|
Looks good to me! |
[api-minor] Change
{PDFPageView, PDFThumbnailView}.updateto take a parameter objectThe old
update-signature started to annoy me back when I added optional content support to the viewer, since we're (often) forced to pass in a bunch of arguments that we don't care about whenever these methods are called.This is tagged
api-minorsincePDFPageViewis being used in thepageviewercomponent example, and it's thus possible that these changes could affect some users; the next commit adds fallback handling for the old format.[GENERIC viewer] Add fallback logic for the old
PDFPageView.updatemethod signatureThis is done separately from the previous commit, to make it easier to revert these changes in the future.