Skip to content

Treat all content as visible when no optional content groups are defined (issue 13971) #13972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 4, 2021
Merged

Treat all content as visible when no optional content groups are defined (issue 13971) #13972

merged 1 commit into from
Sep 4, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

In the referenced PDF document the /Contents stream contains MarkedContent-operators, however no optional content dictionary exists; according to the specification:

Null values or references to deleted objects shall be ignored. If this entry is
not present, is an empty array, or contains references only to null or deleted
objects, the membership dictionary shall have no effect on the visibility of
any content.

Fixes #13971

@Snuffleupagus Snuffleupagus changed the title Treat all content as visible when no optional content group are defined (issue 13971) Treat all content as visible when no optional content groups are defined (issue 13971) Sep 4, 2021
@Snuffleupagus
Treat all content as visible when no optional content groups are defi…
6318ccf 
…ned (issue 13971)

In the referenced PDF document the /Contents stream contains MarkedContent-operators, however no optional content dictionary exists; according to [the specification](https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G7.3883825):

> Null values or references to deleted objects shall be ignored. If this entry is
  not present, is an empty array, or contains references only to null or deleted
  objects,  the  membership  dictionary  shall  have  no  effect  on  the  visibility  of
  any content.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/603e8e1f79a23df/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d9c0578b71cad8e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/603e8e1f79a23df/output.txt

Total script time: 22.25 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 6
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/603e8e1f79a23df/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d9c0578b71cad8e/output.txt

Total script time: 31.39 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 645
  different ref/snapshot: 6
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/d9c0578b71cad8e/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Linux m4)

Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/71c0a3d05d8abfa/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/71c0a3d05d8abfa/output.txt

Total script time: 4.76 mins

Published

@timvandermeij timvandermeij merged commit 1b20f61 into mozilla:master Sep 4, 2021
@timvandermeij
Copy link
Contributor

Thank you for fixing this!

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7baae28c943baf6/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Windows)

Received

Command cmd_makeref from @timvandermeij received. Current queue size: 2

Live output at: http://54.193.163.58:8877/001b61606d0c15e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7baae28c943baf6/output.txt

Total script time: 20.57 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/001b61606d0c15e/output.txt

Total script time: 28.43 mins

  • Lint: Passed
  • Make references: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Windows)

Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/2aed854da1db345/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2021

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/2aed854da1db345/output.txt

Total script time: 36.86 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-13971 branch September 4, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page with empty OCGs entry rendered blank
3 participants
@Snuffleupagus @pdfjsbot @timvandermeij