Skip to content

Always prefer the post-table for TrueType fonts with (0, x) cmap-tables (issue 13433) #13955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

Snuffleupagus
Copy link
Collaborator

While I don't know if this is necessarily the "correct" solution, it does fix issue 13433 without breaking any of the existing reference-tests.

…es (issue 13433)

While I don't know if this is necessarily the "correct" solution, it does fix issue 13433 without breaking any of the existing reference-tests.
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2b87246b26265a0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/ebfbeb04b8f4114/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/ebfbeb04b8f4114/output.txt

Total script time: 31.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  errors: 643
  different ref/snapshot: 9
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/ebfbeb04b8f4114/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/2b87246b26265a0/output.txt

Total script time: 34.16 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 10
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/2b87246b26265a0/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio-windows browsertest

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Windows)


Received

Command cmd_browsertest from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/8f6376579272b97/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/8f6376579272b97/output.txt

Total script time: 35.62 mins

  • Regression tests: FAILED
  different ref/snapshot: 28
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/8f6376579272b97/reftest-analyzer.html#web=eq.log

@timvandermeij
Copy link
Contributor

/botio-windows preview

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Windows)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 1

Live output at: http://3.101.106.178:8877/25a4661b17d21c1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 1, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/25a4661b17d21c1/output.txt

Total script time: 9.29 mins

Published

@timvandermeij timvandermeij merged commit 0a366dd into mozilla:master Sep 1, 2021
@timvandermeij
Copy link
Contributor

Looks simple enough. Thanks!

@Snuffleupagus Snuffleupagus deleted the issue-13433 branch September 3, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chars missing from a document
3 participants