Implement PDFNetworkStreamRangeRequestReader._onError, to handle range request errors with XMLHttpRequest (issue 9883)
#13945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio unittest |
Snuffleupagus
force-pushed
the
network-onError
branch
from
a442a08 to
46203f2
Compare
Also changes the different `_onDone`/`_onProgress` methods to use consistent parameter names, and some other small improvements.
…nge request errors with XMLHttpRequest (issue 9883) Given that the Fetch API is normally being used now, these changes are probably less important now than they used to be. However, given that it's simple enough to implement this I figured why not just fix issue 9883 (better late than never I suppose).
Snuffleupagus
force-pushed
the
network-onError
branch
from
46203f2 to
1f56451
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bafbf206afcfa08/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/65505656d06bb21/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/bafbf206afcfa08/output.txt Total script time: 3.99 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/65505656d06bb21/output.txt Total script time: 5.43 mins
|
timvandermeij
approved these changes
Sep 1, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use optional chaining more in the
src/display/network.jsfileAlso changes the different
_onDone/_onProgressmethods to use consistent parameter names, and some other small improvements.Implement
PDFNetworkStreamRangeRequestReader._onError, to handle range request errors with XMLHttpRequest (issue 9883)Given that the Fetch API is normally being used now, these changes are probably less important now than they used to be. However, given that it's simple enough to implement this I figured why not just fix issue Unhandled range-request errors #9883 (better late than never I suppose).
Fixes #9883