Support Optional Content in Image-/XObjects (issue 13931) #13932
Conversation
|
/botio test |
Snuffleupagus
force-pushed
the
oc-images
branch
from
07f0ff3 to
1cdb5e6
Compare
|
@brendandahl Could you perhaps review this one since it's a follow-up to your initial patch? |
Currently, in the `PartialEvaluator`, we only support Optional Content in Form-/XObjects. Hence this patch adds support for Image-/XObjects as well, which looks like a simple oversight in PR 12095 since the canvas-implementation already contains the necessary code to support this.
…XObjects, are balanced in corrupt documents (PR 13854 follow-up) Something that I *just* realized is that while PR 13854 fixed an issue as reported, it could still cause bugs in other similarily broken documents since we'll not insert a matching endMarkedContent-operator in the operatorList.
Snuffleupagus
force-pushed
the
oc-images
branch
from
1cdb5e6 to
b34d2cd
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f8e0fe45a5af3cf/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/e14cee6211cceeb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/f8e0fe45a5af3cf/output.txt Total script time: 33.72 mins
Image differences available at: http://54.67.70.0:8877/f8e0fe45a5af3cf/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/e14cee6211cceeb/output.txt Total script time: 40.94 mins
Image differences available at: http://3.101.106.178:8877/e14cee6211cceeb/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/32c03410cc0c056/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/32c03410cc0c056/output.txt Total script time: 4.92 mins Published |
|
Nice, thanks for the tests too! |
|
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c0aa900654cea01/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 1 Live output at: http://3.101.106.178:8877/08a08821f5cea57/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/c0aa900654cea01/output.txt Total script time: 30.89 mins
|
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/08a08821f5cea57/output.txt Total script time: 28.81 mins
|
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/93a89fe574d2b16/output.txt |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/93a89fe574d2b16/output.txt Total script time: 37.69 mins
|
Support Optional Content in Image-/XObjects (issue 13931)
Currently, in the
PartialEvaluator, we only support Optional Content in Form-/XObjects. Hence this patch adds support for Image-/XObjects as well, which looks like a simple oversight in PR Add support for optional marked content. #12095 since the canvas-implementation already contains the necessary code to support this.Add support for specifying non-default Optional Content in the ref-tests
Fixes #13931