Fix pdf_viewer definitions #13913
Merged
Fix pdf_viewer definitions #13913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Please include the information from #13913 (comment) in the commit message as well.
Current pdf_viewer definitions result in errors like the following when trying to use them in a ts project: [error] TypeScript error node_modules/.pnpm/[email protected]/node_modules/pdfjs-dist/web/pdf_viewer.d.ts:1:15 - error TS2691: An import path cannot end with a '.d.ts' extension. Consider importing 'pdfjs-dist/types/web/pdf_viewer.component.js' instead. 1 export * from "pdfjs-dist/types/web/pdf_viewer.component.d.ts"; Import/export statements in typescript should not include file extensions.
|
Thanks for the review! I've amended the commit message. |
Snuffleupagus
approved these changes
Aug 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #13588
Current pdf_viewer definitions result in errors like the following when trying to use them in a ts project:
Import/export statements in typescript should not include file extensions.