Remove the isEOF helper function and slightly re-factor EOF
#13859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given how trivial the `isEOF` function is, we can simply inline the check at the various call-sites and remove the function (which ought to be ever so slightly more efficient as well). Furthermore, this patch also changes the `EOF` primitive itself to a `Symbol` instead of an Object since that has the nice benefit of making it unclonable (thus preventing *accidentally* trying to send `EOF` from the worker-thread).
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://3.101.106.178:8877/9955ba7aacb797b/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/38174676a8e4936/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/38174676a8e4936/output.txt Total script time: 33.35 mins
Image differences available at: http://54.67.70.0:8877/38174676a8e4936/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/9955ba7aacb797b/output.txt Total script time: 40.10 mins
Image differences available at: http://3.101.106.178:8877/9955ba7aacb797b/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Aug 3, 2021
|
Thank you for refactoring this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given how trivial the
isEOFfunction is, we can simply inline the check at the various call-sites and remove the function (which ought to be ever so slightly more efficient as well).Furthermore, this patch also changes the
EOFprimitive itself to aSymbolinstead of an Object since that has the nice benefit of making it unclonable (thus preventing accidentally trying to sendEOFfrom the worker-thread).