Prevent "Uncaught promise" messages in the console when cancelling (some) ReadableStreams
#13822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome) `ReadableStream`s While fixing issue 13794, I noticed that cancelling the `ReadableStream` returned by the `PDFPageProxy.streamTextContent`-method could lead to "Uncaught promise" messages in the console.[1] Generally speaking, we don't really care about errors when *cancelling* a `ReadableStream` and it thus seems reasonable to simply suppress any output in those cases. --- [1] Although, after that issue was fixed you'd now need to set the API-option `stopAtErrors = true` to actually trigger this.
Snuffleupagus
force-pushed
the
ReadableStreams-cancel-no-Uncaught_promise
branch
from
b47a480 to
1df9da9
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c51ac4ccb135bb4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/7121490b864d13a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c51ac4ccb135bb4/output.txt Total script time: 33.22 mins
Image differences available at: http://54.67.70.0:8877/c51ac4ccb135bb4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/7121490b864d13a/output.txt Total script time: 38.88 mins
Image differences available at: http://3.101.106.178:8877/7121490b864d13a/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jul 30, 2021
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing issue #13794, I noticed that cancelling the
ReadableStreamreturned by thePDFPageProxy.streamTextContent-method could lead to "Uncaught promise" messages in the console.[1]Generally speaking, we don't really care about errors when cancelling a
ReadableStreamand it thus seems reasonable to simply suppress any output in those cases.[1] Although, after that issue was fixed you'd now need to set the API-option
stopAtErrors = trueto actually trigger this.