[api-minor] Remove the separate enableScripting option in BaseViewer
#13816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to PR 13042, when scripting wasn't really possible to use outside of the full viewer, the `enableScripting` option made sense. However, at this point in time having to both pass in a `PDFScriptingManager`-instance *and* set the `enableScripting`-boolean when creating a `BaseViewer`-instance feels redundant and (mostly) annoying. Hence this patch, which removes the *separate* boolean and always enables scripting when `scriptingManager` is provided. The relevant "viewer component" examples are also updated (with a comment), but in such a way that scripting support won't just break when used with the current PDF.js releases.
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/cf1f4a0d6dedbe2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/2180d7f879ab28c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/cf1f4a0d6dedbe2/output.txt Total script time: 4.39 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/2180d7f879ab28c/output.txt Total script time: 6.40 mins
|
timvandermeij
approved these changes
Jul 30, 2021
|
This does seem simpler to me too; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to PR #13042, when scripting wasn't really possible to use outside of the full viewer, the
enableScriptingoption made sense.However, at this point in time having to both pass in a
PDFScriptingManager-instance and set theenableScripting-boolean when creating aBaseViewer-instance feels redundant and (mostly) annoying. Hence this patch, which removes the separate boolean and always enables scripting whenscriptingManageris provided.The relevant "viewer component" examples are also updated (with a comment), but in such a way that scripting support won't just break when used with the current PDF.js releases.