Remove the remaining closure in the src/display/canvas.js file
#13792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For e.g. the `gulp mozcentral` command, the *built* `pdf.js` file decreases from `304 607` to `301 295` bytes with this patch. The improvement comes mostly from having less overall indentation in the code.
Snuffleupagus
force-pushed
the
rm-canvas-closure
branch
2 times, most recently
from
85b1d32 to
8bef790
Compare
…ethod-names on the `CanvasGraphics.prototype` There's no good reason, as far as I can tell, to explicitly define a bunch of methods to be `undefined`, which the current unconditional "copying" of methods will do. Note that of the `OPS` ~23 percent don't, for various reasons, have an associated method on the `CanvasGraphics.prototype`.
Snuffleupagus
force-pushed
the
rm-canvas-closure
branch
from
8bef790 to
e1fa845
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/43a041db2deb249/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 3 Live output at: http://3.101.106.178:8877/610ebc4559fe5eb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/43a041db2deb249/output.txt Total script time: 32.79 mins
Image differences available at: http://54.67.70.0:8877/43a041db2deb249/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/610ebc4559fe5eb/output.txt Total script time: 37.36 mins
Image differences available at: http://3.101.106.178:8877/610ebc4559fe5eb/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jul 25, 2021
|
Nice clean-up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For e.g. the
gulp mozcentralcommand, the builtpdf.jsfile decreases from304 607to301 295bytes with this patch. The improvement comes mostly from having less overall indentation in the code.Much easier reviewing with https://github.com/mozilla/pdf.js/pull/13792/files?w=1