Skip to content

XFA - Cannot print fields with no names #13734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2021
Merged

XFA - Cannot print fields with no names #13734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/core/xfa/bind.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,10 +478,10 @@ class Binder {
if (dataChildren.length > 0) {
this._bindOccurrences(child, [dataChildren[0]], null);
} else if (this.emptyMerge) {
const dataChild = new XmlObject(
const dataChild = (child[$data] = new XmlObject(
dataNode[$namespaceId],
child.name || "root"
);
));
dataNode[$appendChild](dataChild);
this._bindElement(child, dataChild);
}
Expand Down Expand Up @@ -602,7 +602,10 @@ class Binder {
if (!match) {
// We're in matchTemplate mode so create a node in data to reflect
// what we've in template.
match = new XmlObject(dataNode[$namespaceId], child.name);
match = child[$data] = new XmlObject(
dataNode[$namespaceId],
child.name
);
if (this.emptyMerge) {
match[$consumed] = true;
}
Expand Down
14 changes: 7 additions & 7 deletions src/core/xfa/template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1150,11 +1150,11 @@ class CheckButton extends XFAObject {
groupId = container[$uid];
type = "radio";
className = "xfaRadio";
dataId = container[$data] && container[$data][$uid];
dataId = (container[$data] && container[$data][$uid]) || container[$uid];
} else {
type = "checkbox";
className = "xfaCheckbox";
dataId = field[$data] && field[$data][$uid];
dataId = (field[$data] && field[$data][$uid]) || field[$uid];
}

const input = {
Expand Down Expand Up @@ -1256,7 +1256,7 @@ class ChoiceList extends XFAObject {
const selectAttributes = {
class: ["xfaSelect"],
fieldId: field[$uid],
dataId: field[$data] && field[$data][$uid],
dataId: (field[$data] && field[$data][$uid]) || field[$uid],
style,
};

Expand Down Expand Up @@ -1493,7 +1493,7 @@ class DateTimeEdit extends XFAObject {
attributes: {
type: "text",
fieldId: field[$uid],
dataId: field[$data] && field[$data][$uid],
dataId: (field[$data] && field[$data][$uid]) || field[$uid],
class: ["xfaTextfield"],
style,
},
Expand Down Expand Up @@ -3508,7 +3508,7 @@ class NumericEdit extends XFAObject {
attributes: {
type: "text",
fieldId: field[$uid],
dataId: field[$data] && field[$data][$uid],
dataId: (field[$data] && field[$data][$uid]) || field[$uid],
class: ["xfaTextfield"],
style,
},
Expand Down Expand Up @@ -5397,7 +5397,7 @@ class TextEdit extends XFAObject {
html = {
name: "textarea",
attributes: {
dataId: field[$data] && field[$data][$uid],
dataId: (field[$data] && field[$data][$uid]) || field[$uid],
fieldId: field[$uid],
class: ["xfaTextfield"],
style,
Expand All @@ -5408,7 +5408,7 @@ class TextEdit extends XFAObject {
name: "input",
attributes: {
type: "text",
dataId: field[$data] && field[$data][$uid],
dataId: (field[$data] && field[$data][$uid]) || field[$uid],
fieldId: field[$uid],
class: ["xfaTextfield"],
style,
Expand Down