Add a new "botbrowsertest" gulp-task, to allow running only the browser tests on the bots #13730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er tests on the bots Currently it's possible to run e.g. `gulp unittest`, `gulp fonttest`, and `gulp integrationtest` *separately* on the bots; see https://github.com/mozilla/botio-files-pdfjs However, it's not possible to run *only* the `gulp browsertest` command on the bots without also running the full test-suite. In some cases, e.g. if the "browsertest" times out, having a way to only re-run those would thus save some time and resources. If/when this patch lands, I'll follow-up with a patch adding a new `on_cmd_browsertest.js` file to the https://github.com/mozilla/botio-files-pdfjs repository.
Snuffleupagus
force-pushed
the
botbrowsertest
branch
from
6747ce5 to
2438d5b
Compare
|
Unfortunately this can only be tested locally, since there's not yet a botio-command that can trigger this new gulp-task. |
timvandermeij
approved these changes
Jul 15, 2021
|
Looks good! This has indeed been a bit of a silly missing feature given that the other test targets were supported. |
|
Once you have a PR for |
Snuffleupagus
added a commit
to Snuffleupagus/botio-files-pdfjs
that referenced
this pull request
Jul 16, 2021
This was referenced Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it's possible to run e.g.
gulp unittest,gulp fonttest, andgulp integrationtestseparately on the bots; see https://github.com/mozilla/botio-files-pdfjsHowever, it's not possible to run only the
gulp browsertestcommand on the bots without also running the full test-suite. In some cases, e.g. if the "browsertest" times out, having a way to only re-run those would thus save some time and resources.If/when this patch lands, I'll follow-up with a patch adding a new
on_cmd_browsertest.jsfile to the https://github.com/mozilla/botio-files-pdfjs repository.