Skip to content

XFA - Use fake MyriadPro as a fallback for missing fonts #13714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2021
Merged

XFA - Use fake MyriadPro as a fallback for missing fonts #13714

merged 1 commit into from
Jul 11, 2021

Conversation

calixteman
Copy link
Contributor

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8c045c429ac3ef0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/c3dd6e7408dc59d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/8c045c429ac3ef0/output.txt

Total script time: 32.11 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 36
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/8c045c429ac3ef0/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus reviewed Jul 10, 2021
View reviewed changes
@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/c3dd6e7408dc59d/output.txt

Total script time: 36.70 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 35
  different first/second rendering: 2

Image differences available at: http://3.101.106.178:8877/c3dd6e7408dc59d/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/a97fd1019b43434/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://3.101.106.178:8877/9df12c93ae89a7d/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/a97fd1019b43434/output.txt

Total script time: 32.17 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 39
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/a97fd1019b43434/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/9df12c93ae89a7d/output.txt

Total script time: 36.79 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 36
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/9df12c93ae89a7d/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

It seems that these changes caused a couple of fonts to become italic, which I'm not sure is correct when comparing against Adobe Reader; for example xfa_bug1717668_1 and xfa_issue13679.

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/7f5b78b08cc6f9b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/26ec542eb4befc7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/26ec542eb4befc7/output.txt

Total script time: 32.25 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 39
  different first/second rendering: 3

Image differences available at: http://54.67.70.0:8877/26ec542eb4befc7/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/7f5b78b08cc6f9b/output.txt

Total script time: 36.89 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 38
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/7f5b78b08cc6f9b/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 70434c1 into mozilla:master Jul 11, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/684313ceec69f13/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/59be57d042c8ab6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/684313ceec69f13/output.txt

Total script time: 29.15 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/59be57d042c8ab6/output.txt

Total script time: 34.12 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
font-conversion form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XFA Only some pages render
3 participants
@calixteman @pdfjsbot @Snuffleupagus