Skip to content

XFA - Layout correctly a subform with row layout (bug 1718740) #13680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

calixteman
Copy link
Contributor

  • Fix issues with subformSet elements which are not a real container.

  - Fix issues with subformSet elements which are not a real container.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8449ac8ad6a3f21/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/061ae2cd02dd6c5/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/8449ac8ad6a3f21/output.txt

Total script time: 31.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 67
  different first/second rendering: 3

Image differences available at: http://54.67.70.0:8877/8449ac8ad6a3f21/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/061ae2cd02dd6c5/output.txt

Total script time: 35.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 68
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/061ae2cd02dd6c5/reftest-analyzer.html#web=eq.log

@marco-c
Copy link
Contributor

marco-c commented Jul 6, 2021

firefox-xfa_issue13213-page2 and other pages of the same PDF lost the border on the right.

@calixteman
Copy link
Contributor Author

Some lines are pretty small so sometimes depending on the zoom level and rounding errors the lines are drawn or not.
I checked for the one above and it's the case.

@calixteman calixteman merged commit 90d196a into mozilla:master Jul 6, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1796221b32d2f0d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/90193eaf575743a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/1796221b32d2f0d/output.txt

Total script time: 28.27 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jul 6, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/90193eaf575743a/output.txt

Total script time: 33.22 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the layout5 branch July 6, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants