[api-minor] Support accessing both the original and modified PDF fingerprint #13661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erprint The PDF.js API has only ever supported accessing the original file ID, however the second one that (should) exist in *modified* documents have thus far been completely inaccessible through the API. That seems like a simple oversight, caused e.g. by the viewer not needing it, since it really shouldn't hurt to provide API-users with the ability to check if a PDF document has been modified since its creation.[1] Please refer to https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G13.2261661 for additional information. For an example of how to update existing code to use the new API, please see the changes in the `web/app.js` file included in this patch. *Please note:* While I'm not sure if we'll ever be able to remove the old `PDFDocumentProxy.fingerprint` getter, given that it's existed since "forever", that probably isn't a big deal given that it's now limited to only `GENERIC`-builds. --- [1] Although this obviously depends on the PDF software following the specification, by updating the second file ID as intended.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/bcfb08fa6b25559/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/f8a17c2792616f1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/bcfb08fa6b25559/output.txt Total script time: 3.77 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/f8a17c2792616f1/output.txt Total script time: 5.51 mins
|
timvandermeij
approved these changes
Jul 3, 2021
|
Nice find; thanks! |
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Sep 7, 2021
In mozilla/pdf.js#13661 the API for retrieving PDF fingerprints (aka. File Identifiers) changed. In generic builds of PDF.js the old API remains available, but not in the non-generic one that Firefox's built-in viewer uses. This commit makes Hypothesis use the new API if available or the old API otherwise. The fingerprint value should be the same in both cases. Fixes #3673
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Sep 7, 2021
In mozilla/pdf.js#13661 the API for retrieving PDF fingerprints (aka. File Identifiers) changed. In generic builds of PDF.js the old API remains available, but not in the non-generic one that Firefox's built-in viewer uses. This commit makes Hypothesis use the new API if available or the old API otherwise. The fingerprint value should be the same in both cases. Fixes #3673
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Sep 7, 2021
In mozilla/pdf.js#13661 the API for retrieving PDF fingerprints (aka. File Identifiers) changed. In generic builds of PDF.js the old API remains available, but not in the non-generic one that Firefox's built-in viewer uses. This commit makes Hypothesis use the new API if available or the old API otherwise. The fingerprint value should be the same in both cases. Fixes #3673
robertknight
added a commit
to hypothesis/client
that referenced
this pull request
Sep 9, 2021
In mozilla/pdf.js#13661 the API for retrieving PDF fingerprints (aka. File Identifiers) changed. In generic builds of PDF.js the old API remains available, but not in the non-generic one that Firefox's built-in viewer uses. This commit makes Hypothesis use the new API if available or the old API otherwise. The fingerprint value should be the same in both cases. Fixes #3673
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PDF.js API has only ever supported accessing the original file ID, however the second one that (should) exist in modified documents have thus far been completely inaccessible through the API.
That seems like a simple oversight, caused e.g. by the viewer not needing it, since it really shouldn't hurt to provide API-users with the ability to check if a PDF document has been modified since its creation.[1]
Please refer to https://www.adobe.com/content/dam/acom/en/devnet/pdf/pdfs/PDF32000_2008.pdf#G13.2261661 for additional information.
For an example of how to update existing code to use the new API, please see the changes in the
web/app.jsfile included in this patch.Please note: While I'm not sure if we'll ever be able to remove the old
PDFDocumentProxy.fingerprintgetter, given that it's existed since "forever", that probably isn't a big deal given that it's now limited to onlyGENERIC-builds.[1] Although this obviously depends on the PDF software following the specification, by updating the second file ID as intended.