Skip to content

XFA - Get line height from the font #13614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2021
Merged

XFA - Get line height from the font #13614

merged 1 commit into from
Jun 23, 2021

Conversation

calixteman
Copy link
Contributor

  • when the CSS line-height property is set to 'normal' then the value depends of the user agent. So use a line height based on the font itself and if for any reasons this value is not available use 1.2 as default.
  • it's a partial fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1717681.

@calixteman
Copy link
Contributor Author

calixteman commented Jun 23, 2021 •
edited
Loading

Almost all the xfa reftests should fail but overall I'd say it's an improvement.

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/4070a459e572c08/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/93c1434d034dc6f/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.67.70.0:8877/77e0b2ff5137aa4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/941c5d320959c38/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/4070a459e572c08/output.txt

Total script time: 28.49 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 146

Image differences available at: http://54.67.70.0:8877/4070a459e572c08/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/93c1434d034dc6f/output.txt

Total script time: 32.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 150
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/93c1434d034dc6f/reftest-analyzer.html#web=eq.log

@marco-c
Copy link
Contributor

marco-c commented Jun 23, 2021

There is a regression in firefox-xfa_imm1295e-page2 and firefox-xfa_imm1344e-page2.

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/77e0b2ff5137aa4/output.txt

Total script time: 28.53 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 145
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/77e0b2ff5137aa4/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/941c5d320959c38/output.txt

Total script time: 32.47 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 146
  different first/second rendering: 2

Image differences available at: http://3.101.106.178:8877/941c5d320959c38/reftest-analyzer.html#web=eq.log

@calixteman
XFA - Get line height from the font
e82446f 
  - when the CSS line-height property is set to 'normal' then the value depends of the user agent. So use a line height based on the font itself and if for any reasons this value is not available use 1.2 as default.
  - it's a partial fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1717681.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/027bd75996e0e02/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/fdf9aa5bae8323c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/027bd75996e0e02/output.txt

Total script time: 28.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 171
  different first/second rendering: 3

Image differences available at: http://54.67.70.0:8877/027bd75996e0e02/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/fdf9aa5bae8323c/output.txt

Total script time: 31.99 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 173
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/fdf9aa5bae8323c/reftest-analyzer.html#web=eq.log

marco-c
marco-c approved these changes Jun 23, 2021
View reviewed changes
Copy link
Contributor

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reftests are looking good now.

@calixteman calixteman merged commit 2bae399 into mozilla:master Jun 23, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/b66f1efc20c99e7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/adef59bdb26e613/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/b66f1efc20c99e7/output.txt

Total script time: 25.28 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/adef59bdb26e613/output.txt

Total script time: 29.74 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus left review comments

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@calixteman @pdfjsbot @marco-c @Snuffleupagus @timvandermeij