Skip to content

XFA - Remove empty pages #13598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2021
Merged

XFA - Remove empty pages #13598

merged 1 commit into from
Jun 30, 2021

Conversation

calixteman
Copy link
Contributor

  • it aims to fix XFA DHL Form contains extra, blank pages #13583;
  • because hidden subform and breakBefore some pages can be empty so remove them;
  • don't fail when there is horizontal overflow (except in lr-tb);
  • fix a typo in radial gradient first argument.

@calixteman calixteman requested a review from brendandahl June 21, 2021 07:49
marco-c
marco-c previously approved these changes Jun 21, 2021
View reviewed changes
Copy link
Contributor

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you ensure the reftests are good?

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/f0bf41b62dc27c1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/031549980060360/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/031549980060360/output.txt

Total script time: 28.39 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/031549980060360/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

There is a regression with imm1344e.pdf.

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/f0bf41b62dc27c1/output.txt

Total script time: 32.40 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/f0bf41b62dc27c1/reftest-analyzer.html#web=eq.log

@marco-c marco-c dismissed their stale review June 22, 2021 07:57

Tests are failing

@calixteman calixteman force-pushed the dhl branch 2 times, most recently from a442f7e to 6916f7e Compare June 26, 2021 20:16
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/e470c3d9551d6c9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f0c44959d5e1984/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/f0c44959d5e1984/output.txt

Total script time: 28.82 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 32

Image differences available at: http://54.67.70.0:8877/f0c44959d5e1984/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/e470c3d9551d6c9/output.txt

Total script time: 33.13 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 34
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/e470c3d9551d6c9/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

The differences for xfa_bug1716816 are expected.

marco-c
marco-c previously approved these changes Jun 28, 2021
View reviewed changes
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/54cf3860b05b3f8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/6b78ff3c6d276d4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/54cf3860b05b3f8/output.txt

Total script time: 29.67 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 46
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/54cf3860b05b3f8/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/6b78ff3c6d276d4/output.txt

Total script time: 33.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 42
  different first/second rendering: 2

Image differences available at: http://3.101.106.178:8877/6b78ff3c6d276d4/reftest-analyzer.html#web=eq.log

@marco-c marco-c dismissed their stale review June 29, 2021 10:08

It looks like there is a regression in firefox-xfa_bug1718037-page4

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/29f56e64e525266/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/5a541090a7db258/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/5a541090a7db258/output.txt

Total script time: 29.62 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 42
  different first/second rendering: 2

Image differences available at: http://54.67.70.0:8877/5a541090a7db258/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/29f56e64e525266/output.txt

Total script time: 34.68 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 40
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/29f56e64e525266/reftest-analyzer.html#web=eq.log

@calixteman
XFA - Remove empty pages
ff440d1 
  - it aims to fix mozilla#13583;
  - fix the switch to breakBefore target;
  - force the layout of an unsplittable element on an empty page;
  - don't fail when there is horizontal overflow (except in lr-tb);
  - handle correctly overflow in the same content area (bug 1717805, bug 1717668);
  - fix a typo in radial gradient first argument.
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/8c0434ab9767a58/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/85d628873378e0b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/8c0434ab9767a58/output.txt

Total script time: 30.37 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 41
  different first/second rendering: 1

Image differences available at: http://54.67.70.0:8877/8c0434ab9767a58/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/85d628873378e0b/output.txt

Total script time: 35.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 40
  different first/second rendering: 1

Image differences available at: http://3.101.106.178:8877/85d628873378e0b/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit d80651e into mozilla:master Jun 30, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/e53c633cc8158e2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/fa15b13663e7899/output.txt

@timvandermeij timvandermeij removed the request for review from brendandahl June 30, 2021 19:08
@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/e53c633cc8158e2/output.txt

Total script time: 27.03 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/fa15b13663e7899/output.txt

Total script time: 32.81 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-c marco-c marco-c approved these changes

Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

XFA DHL Form contains extra, blank pages
3 participants
@calixteman @pdfjsbot @marco-c