Skip to content

XFA - Fix layout issues (again) #13479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2021
Merged

XFA - Fix layout issues (again) #13479

merged 1 commit into from
Jun 8, 2021

Conversation

calixteman
Copy link
Contributor

XFA - Fix layout issues (again)

  • some elements weren't displayed because their rotation angle was not taken into account;
  • fix box model (XFA concept):
  • move border on button instead of having it on wrapping div;

@calixteman calixteman force-pushed the margin branch 5 times, most recently from f6628b0 to 417646e Compare June 4, 2021 18:14
@calixteman calixteman requested a review from brendandahl June 4, 2021 18:14
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/cd2f34d3ad2a4ed/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/f7494248829bc24/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/cd2f34d3ad2a4ed/output.txt

Total script time: 25.77 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/cd2f34d3ad2a4ed/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/f7494248829bc24/output.txt

Total script time: 29.29 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/f7494248829bc24/reftest-analyzer.html#web=eq.log

@calixteman calixteman force-pushed the margin branch 2 times, most recently from 02674bc to 6935b84 Compare June 7, 2021 14:34
@calixteman
XFA - Fix layout issues (again)
cfa7274 
  - some elements weren't displayed because their rotation angle was not taken into account;
  - fix box model (XFA concept):
    - remove use of outline;
    - position correctly border which isn't part of box dimensions;
    - fix margins issues (see issue mozilla#13474).
  - move border on button instead of having it on wrapping div;
@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/6bfc393b9c515fa/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/82e3323ff9d7e97/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Linux m4)

Failed

Full output at http://54.67.70.0:8877/6bfc393b9c515fa/output.txt

Total script time: 26.18 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/6bfc393b9c515fa/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Windows)

Failed

Full output at http://3.101.106.178:8877/82e3323ff9d7e97/output.txt

Total script time: 29.85 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/82e3323ff9d7e97/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/21b4be83a40243f/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Windows)

Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/0e4bb839bf885b3/output.txt

@brendandahl brendandahl merged commit 2a61110 into mozilla:master Jun 8, 2021
@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/21b4be83a40243f/output.txt

Total script time: 22.96 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 8, 2021

From: Bot.io (Windows)

Success

Full output at http://3.101.106.178:8877/0e4bb839bf885b3/output.txt

Total script time: 27.06 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus mentioned this pull request Jun 8, 2021
Closed
@timvandermeij timvandermeij removed the request for review from brendandahl June 9, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
form-xfa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixteman @pdfjsbot @brendandahl @timvandermeij