-
Notifications
You must be signed in to change notification settings - Fork 10.3k
XFA - Fix lot of layout issues #13402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
31c06e3
to
4ccdaa7
Compare
30f040c
to
28483a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ needs the comment in layout.js updated though.
- I thought it was possible to rely on browser layout engine to handle layout stuff but it isn't possible - mainly because when a contentArea overflows, we must continue to layout in the next contentArea - when no more contentArea is available then we must go to the next page... - we must handle breakBefore and breakAfter which allows to "break" the layout to go to the next container - Sometimes some containers don't provide their dimensions so we must compute them in order to know where to put them in their parents but to compute those dimensions we need to layout the container itself... - See top of file layout.js for more explanations about layout. - fix few bugs in other places I met during my work on layout.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b1eeef2bfa5009d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/783a046d416a15c/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b1eeef2bfa5009d/output.txt Total script time: 0.00 mins |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/783a046d416a15c/output.txt Total script time: 5.64 mins
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/1ba657f6ce2cbe3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/1ba657f6ce2cbe3/output.txt Total script time: 0.00 mins |
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/7ff2c8ada75a912/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/7ff2c8ada75a912/output.txt Total script time: 3.02 mins
|
them in their parents but to compute those dimensions we need to layout the container itself...