Skip to content

Replace command with not enough args by an endchar in CFF font #13376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

calixteman
Copy link
Contributor

@calixteman calixteman commented May 14, 2021

  • Right now, a glyph with an erroneous outline is replaced by an empty glyph
    if the error is far enough from the start there's likely something to render
    so the idea is to replace a command with args by an endchar when no args are
    on the stack: this way OTS is likely happy (no remaining args on stack) and we
    can draw something which is likely better than nothing.
  • it aims to fix Many characters in this PDF are not drawn #6132

  - Right now, a glyph with an erroneous outline is replaced by an empty glyph
    if the error is far enough from the start there's likely something to render
    so the idea is to replace a command with args by an endchar when no args are
    on the stack: this way OTS is likely happy (no remaining args on stack) and we
    can draw something which is likely better than nothing.
@calixteman
Copy link
Contributor Author

Interestingly, I disabled charStrings validation and OTS in Firefox complained about wrong charStrings but the pdf was well-rendered and fontForge doesn't complain about those fonts.

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/34a08f1605cdac4/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://3.101.106.178:8877/5924c9f493f63db/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/34a08f1605cdac4/output.txt

Total script time: 26.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/34a08f1605cdac4/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/5924c9f493f63db/output.txt

Total script time: 30.30 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/5924c9f493f63db/reftest-analyzer.html#web=eq.log

@brendandahl
Copy link
Contributor

/botio makeref

@brendandahl brendandahl closed this Jun 4, 2021
@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://54.67.70.0:8877/65647927b2daa8e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/f3cb9721252e88a/output.txt

@brendandahl brendandahl reopened this Jun 4, 2021
@brendandahl brendandahl merged commit 6255c2a into mozilla:master Jun 4, 2021
@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/65647927b2daa8e/output.txt

Total script time: 22.55 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Jun 4, 2021

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/f3cb9721252e88a/output.txt

Total script time: 26.55 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@timvandermeij timvandermeij removed the request for review from brendandahl June 5, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many characters in this PDF are not drawn
4 participants