-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Replace command with not enough args by an endchar in CFF font #13376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Right now, a glyph with an erroneous outline is replaced by an empty glyph if the error is far enough from the start there's likely something to render so the idea is to replace a command with args by an endchar when no args are on the stack: this way OTS is likely happy (no remaining args on stack) and we can draw something which is likely better than nothing.
Interestingly, I disabled charStrings validation and OTS in Firefox complained about wrong charStrings but the pdf was well-rendered and fontForge doesn't complain about those fonts. |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/34a08f1605cdac4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/5924c9f493f63db/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/34a08f1605cdac4/output.txt Total script time: 26.24 mins
Image differences available at: http://54.67.70.0:8877/34a08f1605cdac4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/5924c9f493f63db/output.txt Total script time: 30.30 mins
Image differences available at: http://3.101.106.178:8877/5924c9f493f63db/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/65647927b2daa8e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/f3cb9721252e88a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/65647927b2daa8e/output.txt Total script time: 22.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/f3cb9721252e88a/output.txt Total script time: 26.55 mins
|
if the error is far enough from the start there's likely something to render
so the idea is to replace a command with args by an endchar when no args are
on the stack: this way OTS is likely happy (no remaining args on stack) and we
can draw something which is likely better than nothing.