-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Set CFF header to 4 when writing it because it contains 4 elements #13149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with the comment addressed and all tests passing; thank you!
src/core/cff_parser.js
Outdated
@@ -1556,7 +1556,9 @@ class CFFCompiler { | |||
} | |||
|
|||
compileHeader(header) { | |||
return [header.major, header.minor, header.hdrSize, header.offSize]; | |||
// `header.hdrSize` can be any value but we only write 4 values | |||
// so header size is 4. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please mention that we're doing this to appease OTS, hence the following would be a nice addition to this comment:
// so the header size must be 4 (prevents OTS from rejecting the font).
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 2 Live output at: http://54.67.70.0:8877/51074faae189df7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://3.101.106.178:8877/d7db4adfd9e3f5a/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/51074faae189df7/output.txt Total script time: 26.20 mins
Image differences available at: http://54.67.70.0:8877/51074faae189df7/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/d7db4adfd9e3f5a/output.txt Total script time: 28.88 mins
Image differences available at: http://3.101.106.178:8877/d7db4adfd9e3f5a/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ffded6f6bc3389d/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ffded6f6bc3389d/output.txt Total script time: 0.18 mins |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eff87d9bc04086a/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/eff87d9bc04086a/output.txt Total script time: 23.46 mins
|
/botio-windows makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/408992cc74b3abe/output.txt |
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/408992cc74b3abe/output.txt Total script time: 27.14 mins
|
it aims to fix issue #13147.