Skip to content

Set CFF header to 4 when writing it because it contains 4 elements #13149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

calixteman
Copy link
Contributor

it aims to fix issue #13147.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with the comment addressed and all tests passing; thank you!

@@ -1556,7 +1556,9 @@ class CFFCompiler {
}

compileHeader(header) {
return [header.major, header.minor, header.hdrSize, header.offSize];
// `header.hdrSize` can be any value but we only write 4 values
// so header size is 4.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please mention that we're doing this to appease OTS, hence the following would be a nice addition to this comment:

    // so the header size must be 4 (prevents OTS from rejecting the font).

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 2

Live output at: http://54.67.70.0:8877/51074faae189df7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://3.101.106.178:8877/d7db4adfd9e3f5a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/51074faae189df7/output.txt

Total script time: 26.20 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://54.67.70.0:8877/51074faae189df7/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://3.101.106.178:8877/d7db4adfd9e3f5a/output.txt

Total script time: 28.88 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED

Image differences available at: http://3.101.106.178:8877/d7db4adfd9e3f5a/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 81c602c into mozilla:master Mar 26, 2021
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/ffded6f6bc3389d/output.txt

@calixteman calixteman deleted the 13147 branch March 26, 2021 17:23
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/ffded6f6bc3389d/output.txt

Total script time: 0.18 mins

@calixteman calixteman restored the 13147 branch March 26, 2021 17:33
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.67.70.0:8877/eff87d9bc04086a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/eff87d9bc04086a/output.txt

Total script time: 23.46 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@brendandahl
Copy link
Contributor

/botio-windows makeref

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_makeref from @brendandahl received. Current queue size: 0

Live output at: http://3.101.106.178:8877/408992cc74b3abe/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://3.101.106.178:8877/408992cc74b3abe/output.txt

Total script time: 27.14 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants