Don't provide the enableXfa parameter to the BaseViewer constructor, and avoid the fallback bar with enableXfa = true set (PR 13069 follow-up)
#13125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Snuffleupagus
force-pushed
the
BaseViewer-enableXfa
branch
2 times, most recently
from
ca2492a to
b34ea06
Compare
Snuffleupagus
changed the title
enableXfa parameter in the BaseViewer (PR 13069 follow-up)enableXfa parameter to the BaseViewer constructor, and avoid the fallback bar with enableXfa = true set (PR 13069 follow-up)
…or, and avoid the fallback bar with `enableXfa = true` set (PR 13069 follow-up) Given that the `enableXfa` parameter must to be passed to the API/Worker, and thus included in the `getDocument` call, it's not necessary to include it when initializing the `PDFViewer`-instance used in the default viewer. (Also, in `AppOptions`, the parameter is clearly marked with `OptionKind.API`.) Furthermore, we probably don't want to display the fallback bar (in Firefox) for XFA documents when `enableXfa = true` is set.
Snuffleupagus
force-pushed
the
BaseViewer-enableXfa
branch
from
b34ea06 to
35a088f
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/02127a4ac55cccb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/02127a4ac55cccb/output.txt Total script time: 4.27 mins Published |
timvandermeij
approved these changes
Mar 21, 2021
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the
enableXfaparameter must to be passed to the API/Worker, and thus included in thegetDocumentcall, it's not necessary to include it when initializing thePDFViewer-instance used in the default viewer. (Also, inAppOptions, the parameter is clearly marked withOptionKind.API.)Furthermore, we probably don't want to display the fallback bar (in Firefox) for XFA documents when
enableXfa = trueis set.