Ignore some *scripting* events which don't make sense in PresentationMode #13113
Conversation
…Mode A number of the currently supported *scripting* events only make sense in the "normal" viewer mode, and not when PresentationMode is active. For example: - Changing the zoom-level will outright break rendering in PresentationMode, since it relies on "page-fit" being used. - Focusing a particular (AcroForm) element won't work, and could break keyboard navigation, since forms should not be editable in PresentationMode (see issue 12232).
Snuffleupagus
force-pushed
the
scripting-PresentationMode-events
branch
from
1cfde44 to
1fa5ce7
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/749a241fcefa88b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/749a241fcefa88b/output.txt Total script time: 4.25 mins Published |
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/feb7eb0a1f5ae48/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d86423c0e301138/output.txt |
|
Maybe we should disable scripting when in presentation mode, wdyt ? |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d86423c0e301138/output.txt Total script time: 3.22 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/feb7eb0a1f5ae48/output.txt Total script time: 4.84 mins
|
My initial though was exactly the same, but there may be some cases where scripting actually make sense even in PresentationMode. See e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1100769, which is currently not working because of an error being thrown in the sandbox, but is probably something that users would expect to work also in PresentationMode. Edit: Apparently the relevant methods are not implemented yet, hence the error: pdf.js/src/scripting_api/doc.js Lines 901 to 907 in 57e7557 |
|
Looks good to me; thanks! |
A number of the currently supported scripting events only make sense in the "normal" viewer mode, and not when PresentationMode is active. For example: