print: Remove invalid @supports condition. #13101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
|
@emilio The CI failed due to a linting error. You can most likely fix it automatically by running |
@supports() is not supposed to report support for page descriptors, this is depending on a Chromium bug, which doesn't treat as invalid: ``` <div style="size: 1pt 1pt"> ``` Even though it should. That is https://bugs.chromium.org/p/chromium/issues/detail?id=1079214 There's no need to use @supports for this. If the descriptor is not accepted it will just be ignored. That way, when Firefox implements @page { size }, which is in progress, it will get the right behavior.
|
Thanks, fixed! |
emilio
force-pushed
the
print-bogus-supports
branch
from
ec82003 to
b932eaf
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/0f48b3a1f755ac0/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/0f48b3a1f755ac0/output.txt Total script time: 4.17 mins Published |
timvandermeij
approved these changes
Mar 14, 2021
|
Looks good and successfully tested in various browsers to check that nothing changed about the printing output. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@supports() is not supposed to report support for page descriptors, this is
depending on a Chromium bug, which doesn't treat as invalid:
Even though it should. That is
https://bugs.chromium.org/p/chromium/issues/detail?id=1079214
There's no need to use @supports for this. If the descriptor is not accepted it
will just be ignored.
That way, when Firefox implements @page { size }, which is in progress, it will
get the right behavior.