Skip to content

Enable the ESLint no-var rule in the test/stats/ folder #13096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2021
Merged

Enable the ESLint no-var rule in the test/stats/ folder #13096

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 40 additions & 50 deletions test/stats/statcmp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,12 @@
/* eslint-disable no-var */

"use strict";

var fs = require("fs");

try {
var ttest = require("ttest");
} catch (e) {
console.log('\nttest is not installed -- to intall, run "npm install ttest"');
console.log("Continuing without significance test...\n");
}
const fs = require("fs");
const ttest = require("ttest");

var VALID_GROUP_BYS = ["browser", "pdf", "page", "round", "stat"];
const VALID_GROUP_BYS = ["browser", "pdf", "page", "round", "stat"];

function parseOptions() {
var yargs = require("yargs")
const yargs = require("yargs")
.usage(
"Compare the results of two stats files.\n" +
"Usage:\n $0 <BASELINE> <CURRENT> [options]"
Expand All @@ -27,7 +19,7 @@ function parseOptions() {
VALID_GROUP_BYS.join(" ")
)
.default("groupBy", "browser,stat");
var result = yargs.argv;
const result = yargs.argv;
result.baseline = result._[0];
result.current = result._[1];
if (result.groupBy) {
Expand All @@ -37,14 +29,14 @@ function parseOptions() {
}

function group(stats, groupBy) {
var vals = [];
for (var i = 0; i < stats.length; i++) {
var curStat = stats[i];
var keyArr = [];
for (var j = 0; j < groupBy.length; j++) {
const vals = [];
for (let i = 0; i < stats.length; i++) {
const curStat = stats[i];
const keyArr = [];
for (let j = 0; j < groupBy.length; j++) {
keyArr.push(curStat[groupBy[j]]);
}
var key = keyArr.join(",");
const key = keyArr.join(",");
if (vals[key] === undefined) {
vals[key] = [];
}
Expand All @@ -58,7 +50,7 @@ function group(stats, groupBy) {
* Also, if results are not grouped by 'stat', keep only 'Overall' results.
*/
function flatten(stats) {
var rows = [];
let rows = [];
stats.forEach(function (curStat) {
curStat.stats.forEach(function (s) {
rows.push({
Expand All @@ -82,7 +74,7 @@ function flatten(stats) {

function pad(s, length, dir /* default: 'right' */) {
s = "" + s;
var spaces = new Array(Math.max(0, length - s.length + 1)).join(" ");
const spaces = new Array(Math.max(0, length - s.length + 1)).join(" ");
return dir === "left" ? spaces + s : s + spaces;
}

Expand All @@ -97,11 +89,11 @@ function mean(array) {
function compareRow(a, b) {
a = a.split(",");
b = b.split(",");
for (var i = 0; i < Math.min(a.length, b.length); i++) {
var intA = parseInt(a[i], 10);
var intB = parseInt(b[i], 10);
var ai = isNaN(intA) ? a[i] : intA;
var bi = isNaN(intB) ? b[i] : intB;
for (let i = 0; i < Math.min(a.length, b.length); i++) {
const intA = parseInt(a[i], 10);
const intB = parseInt(b[i], 10);
const ai = isNaN(intA) ? a[i] : intA;
const bi = isNaN(intB) ? b[i] : intB;
if (ai < bi) {
return -1;
}
Expand All @@ -125,30 +117,28 @@ function compareRow(a, b) {
* be implied.
*/
function stat(baseline, current) {
var baselineGroup = group(baseline, options.groupBy);
var currentGroup = group(current, options.groupBy);
const baselineGroup = group(baseline, options.groupBy);
const currentGroup = group(current, options.groupBy);

var keys = Object.keys(baselineGroup);
const keys = Object.keys(baselineGroup);
keys.sort(compareRow);

var labels = options.groupBy.slice(0);
const labels = options.groupBy.slice(0);
labels.push("Count", "Baseline(ms)", "Current(ms)", "+/-", "% ");
if (ttest) {
labels.push("Result(P<.05)");
}
var i,
row,
rows = [];
const rows = [];
// collect rows and measure column widths
var width = labels.map(function (s) {
const width = labels.map(function (s) {
return s.length;
});
rows.push(labels);
for (var k = 0; k < keys.length; k++) {
var key = keys[k];
var baselineMean = mean(baselineGroup[key]);
var currentMean = mean(currentGroup[key]);
row = key.split(",");
for (let k = 0; k < keys.length; k++) {
const key = keys[k];
const baselineMean = mean(baselineGroup[key]);
const currentMean = mean(currentGroup[key]);
const row = key.split(",");
row.push(
"" + baselineGroup[key].length,
"" + Math.round(baselineMean),
Expand All @@ -157,7 +147,7 @@ function stat(baseline, current) {
((100 * (currentMean - baselineMean)) / baselineMean).toFixed(2)
);
if (ttest) {
var p =
const p =
baselineGroup[key].length < 2
? 1
: ttest(baselineGroup[key], currentGroup[key]).pValue();
Expand All @@ -167,41 +157,41 @@ function stat(baseline, current) {
row.push("");
}
}
for (i = 0; i < row.length; i++) {
for (let i = 0; i < row.length; i++) {
width[i] = Math.max(width[i], row[i].length);
}
rows.push(row);
}

// add horizontal line
var hline = width.map(function (w) {
const hline = width.map(function (w) {
return new Array(w + 1).join("-");
});
rows.splice(1, 0, hline);

// print output
console.log("-- Grouped By " + options.groupBy.join(", ") + " --");
var groupCount = options.groupBy.length;
for (var r = 0; r < rows.length; r++) {
row = rows[r];
for (i = 0; i < row.length; i++) {
const groupCount = options.groupBy.length;
for (let r = 0; r < rows.length; r++) {
const row = rows[r];
for (let i = 0; i < row.length; i++) {
row[i] = pad(row[i], width[i], i < groupCount ? "right" : "left");
}
console.log(row.join(" | "));
}
}

function main() {
var baseline, current;
let baseline, current;
try {
var baselineFile = fs.readFileSync(options.baseline).toString();
const baselineFile = fs.readFileSync(options.baseline).toString();
baseline = flatten(JSON.parse(baselineFile));
} catch (e) {
console.log('Error reading file "' + options.baseline + '": ' + e);
process.exit(0);
}
try {
var currentFile = fs.readFileSync(options.current).toString();
const currentFile = fs.readFileSync(options.current).toString();
current = flatten(JSON.parse(currentFile));
} catch (e) {
console.log('Error reading file "' + options.current + '": ' + e);
Expand All @@ -210,5 +200,5 @@ function main() {
stat(baseline, current);
}

var options = parseOptions();
const options = parseOptions();
main();