Enable the ESLint no-var rule globally
#13091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A significant portion of the code-base has now been converted to use `let`/`const`, rather than `var`, hence it should be possible to simply enable the ESLint `no-var` rule globally. This way we can ensure that new code won't accidentally use `var`, and it also removes the need to manually enable the rule in various folders. Obviously it makes sense to continue the efforts to replace `var`, but that should probably happen on a file and/or folder basis. Please note that this patch excludes the following code: - The `extensions/` folder, since that seemed easiest for now (and I don't know exactly what the support situation is for the Chromium-extension). - The entire `external/` folder is ignored, since most of it's currently excluded from linting. For the code that isn't imported from elsewhere (and should be ignored), we should probably (at some point) bring the code up to the same linting/formatting standard as the rest of the code-base. - Various files in the `test/` folder are ignored, as necessary, since the way that a lot of this code is loaded will require some care (or perhaps larger re-factoring) when removing `var` usage.
|
/botio lint |
From: Bot.io (Linux m4)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/e02a75d412962d2/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/05b7093fd4e1d87/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/e02a75d412962d2/output.txt Total script time: 2.46 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/05b7093fd4e1d87/output.txt Total script time: 4.11 mins
|
timvandermeij
approved these changes
Mar 13, 2021
|
Good idea! I fiddled with the test code before and also found that some code should ideally be refactored first to make the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A significant portion of the code-base has now been converted to use
let/const, rather thanvar, hence it should be possible to simply enable the ESLintno-varrule globally.This way we can ensure that new code won't accidentally use
var, and it also removes the need to manually enable the rule in various folders.Obviously it makes sense to continue the efforts to replace
var, but that should probably happen on a file and/or folder basis.Please note that this patch excludes the following code:
The
extensions/folder, since that seemed easiest for now (and I don't know exactly what the support situation is for the Chromium-extension).The entire
external/folder is ignored, since most of it's currently excluded from linting.For the code that isn't imported from elsewhere (and should be ignored), we should probably (at some point) bring the code up to the same linting/formatting standard as the rest of the code-base.
Various files in the
test/folder are ignored, as necessary, since the way that a lot of this code is loaded will require some care (or perhaps larger re-factoring) when removingvarusage.