Enable the ESLint no-var rule in gulpfile.js
#13090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that `let`/`const` is already used here and there in this file, converting the rest of the `var` occurrences shouldn't be a problem. Note that the majority of these changes were done automatically, by using the `gulp lint --fix` command, and the manual changes were limited to the following diff: ```diff diff --git a/gulpfile.js b/gulpfile.js index e2360c8ec..905420c 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -676,8 +676,8 @@ gulp.task("default_preferences-pre", function () { ], }).code; } - var babel = require("@babel/core"); - var ctx = { + const babel = require("@babel/core"); + const ctx = { rootPath: __dirname, saveComments: false, defines: builder.merge(DEFINES, { @@ -690,7 +690,7 @@ gulp.task("default_preferences-pre", function () { "pdfjs-lib": "../pdf", }, }; - var preprocessor2 = require("./external/builder/preprocessor2.js"); + const preprocessor2 = require("./external/builder/preprocessor2.js"); return merge([ gulp.src(["web/{app_options,viewer_compatibility}.js"], { base: ".", @@ -1418,14 +1418,14 @@ function buildLib(defines, dir) { }); return licenseHeaderLibre + content; } - var babel = require("@babel/core"); + const babel = require("@babel/core"); const versionInfo = getVersionJSON(); - var bundleDefines = builder.merge(defines, { + const bundleDefines = builder.merge(defines, { BUNDLE_VERSION: versionInfo.version, BUNDLE_BUILD: versionInfo.commit, TESTING: process.env.TESTING === "true", }); - var ctx = { + const ctx = { rootPath: __dirname, saveComments: false, defines: bundleDefines, @@ -1433,10 +1433,10 @@ function buildLib(defines, dir) { "pdfjs-lib": "../pdf", }, }; - var licenseHeaderLibre = fs + const licenseHeaderLibre = fs .readFileSync("./src/license_header_libre.js") .toString(); - var preprocessor2 = require("./external/builder/preprocessor2.js"); + const preprocessor2 = require("./external/builder/preprocessor2.js"); return merge([ gulp.src( [ ```
…it/` folder (PR 12528 follow-up) These lines are no longer needed, since the ESLint `no-var` rule has been enabled in the entire folder.
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/31e418e9d0abb1e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/60c996e4b63d483/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/31e418e9d0abb1e/output.txt Total script time: 3.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/60c996e4b63d483/output.txt Total script time: 5.24 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/64d22eecc5a748c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/64d22eecc5a748c/output.txt Total script time: 4.07 mins Published |
timvandermeij
approved these changes
Mar 13, 2021
|
Looks good; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please refer to the individual commit messages for additional details.