-
Notifications
You must be signed in to change notification settings - Fork 10.3k
XFA - Convert some template properties into CSS ones #13082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
calixteman
commented
Mar 11, 2021
- implement few positioning properties: position, width, height, anchor;
- implement font element; - implement fill element (used by font) and its children (linear, radial, ...);
- font property is inherited from ancestor container (see https://www.pdfa.org/wp-content/uploads/2020/07/XFA-3_3.pdf#page=43) so let CSS handles that stuff;
- in order to reduce the number of properties to set, only set non default properties and put the default in CSS;
- set a background to some containers to be able to see them (will be removed in a future commit).
4af35ca
to
327cc8a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ one thing to confirm and css nit, but good to go after that
- implement few positioning properties: position, width, height, anchor; - implement font element; - implement fill element (used by font) and its children (linear, radial, ...); - font property is inherited from ancestor container (see https://www.pdfa.org/wp-content/uploads/2020/07/XFA-3_3.pdf#page=43) so let CSS handles that stuff; - in order to reduce the number of properties to set, only set non default properties and put the default in CSS; - set a background to some containers to be able to see them (will be removed in a future commit).
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8e68dafeda8a025/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/7b8f70d6e79f57b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8e68dafeda8a025/output.txt Total script time: 60.00 mins |
Firefox crashed on the windows bot because of (likely the same for the linux one): |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.67.70.0:8877/c26d56a1e173d82/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/23b476663d24b3e/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/c26d56a1e173d82/output.txt Total script time: 25.62 mins
Image differences available at: http://54.67.70.0:8877/c26d56a1e173d82/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/23b476663d24b3e/output.txt Total script time: 28.96 mins
Image differences available at: http://3.101.106.178:8877/23b476663d24b3e/reftest-analyzer.html#web=eq.log |