XFA - Create Form DOM in merging template and data trees #13018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
calixteman
commented
Feb 24, 2021
calixteman
commented
- Spec: http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.364.2157&rep=rep1&type=pdf#page=171;
- support for the 2 ways of merging: consumeData and matchTemplate;
- create additional nodes in template DOM when occur node allows it;
- support for global values in data DOM.
brendandahl
suggested changes
Mar 4, 2021
src/core/document.js
Outdated
| @@ -732,6 +734,53 @@ class PDFDocument { | |||
| }); | |||
| } | |||
|
|
|||
| get xfaData() { | |||
src/core/xfa/template.js
Outdated
| ); | ||
| } | ||
|
|
||
| static [$newInstance]() { |
There was a problem hiding this comment.
Do we need to use the $ format for a static field?
src/core/xfa/xfa_object.js
Outdated
| @@ -159,6 +218,7 @@ class XFAObject { | |||
|
|
|||
| [$dump]() { | |||
| const dumped = Object.create(null); | |||
| // dumped.$nodeName = this[$nodeName]; | |||
src/core/xfa/xfa_object.js
Outdated
| @@ -640,10 +750,24 @@ class Option10 extends IntegerObject { | |||
| } | |||
| } | |||
|
|
|||
| function isChild(node, parentNode) { | |||
There was a problem hiding this comment.
If this only works on XFAObjects can it be in the class instead. e.g. someNode[$isChildOf](parentNode) Also, a slightly more accurate name would be isDescendent
| } | ||
| } | ||
|
|
||
| _findDataByNameToConsume(name, dataNode, global) { |
There was a problem hiding this comment.
Can you add some comments on what is being searched first, second, ....
- Spec: http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.364.2157&rep=rep1&type=pdf#page=171; - support for the 2 ways of merging: consumeData and matchTemplate; - create additional nodes in template DOM when occur node allows it; - support for global values in data DOM.
|
/botio-linux unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ec5ab465eef8755/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/ec5ab465eef8755/output.txt Total script time: 3.60 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.