[api-minor] Support the Content-Disposition filename in the Firefox PDF Viewer (bug 1694556, PR 9379 follow-up) #13014
Conversation
Snuffleupagus
force-pushed
the
Firefox-contentDispositionFilename
branch
2 times, most recently
from
aefc0ce to
803c893
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/96bb0fb1e72ab57/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/527258a60842289/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/96bb0fb1e72ab57/output.txt Total script time: 3.57 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/527258a60842289/output.txt Total script time: 7.04 mins
|
Snuffleupagus
force-pushed
the
Firefox-contentDispositionFilename
branch
2 times, most recently
from
0f85c42 to
bbedcc7
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d431ee008f8d565/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/4878fb45b384719/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/d431ee008f8d565/output.txt Total script time: 3.59 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/4878fb45b384719/output.txt Total script time: 5.17 mins
|
Snuffleupagus
force-pushed
the
Firefox-contentDispositionFilename
branch
from
bbedcc7 to
1c5b4e2
Compare
…DF Viewer (bug 1694556, PR 9379 follow-up) As can be seen [in the mozilla-central code](https://searchfox.org/mozilla-central/rev/a6db3bd67367aa9ddd9505690cab09b47e65a762/toolkit/components/pdfjs/content/PdfStreamConverter.jsm#1222-1225), we're already getting the Content-Disposition filename. However, that data isn't passed through to the viewer nor to the `PDFDataTransportStream`-implementation, which explains why it's currently being ignored. *Please note:* This will also require a small mozilla-central patch, see https://bugzilla.mozilla.org/show_bug.cgi?id=1694556, to forward the necessary data to the viewer.
Snuffleupagus
force-pushed
the
Firefox-contentDispositionFilename
branch
from
1c5b4e2 to
6fd899d
Compare
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9a80d71e4eade32/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/bfe0524ccf8f9bb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9a80d71e4eade32/output.txt Total script time: 3.55 mins
|
From: Bot.io (Windows)SuccessFull output at http://3.101.106.178:8877/bfe0524ccf8f9bb/output.txt Total script time: 5.64 mins
|
…. r=bdahl *Please note:* This will require mozilla/pdf.js#13014 landing first. Differential Revision: https://phabricator.services.mozilla.com/D106272
…. r=bdahl *Please note:* This will require mozilla/pdf.js#13014 landing first. Differential Revision: https://phabricator.services.mozilla.com/D106272 UltraBlame original commit: 3f23121524b1cee78069c8e0cc73a850ccd987c2
…. r=bdahl *Please note:* This will require mozilla/pdf.js#13014 landing first. Differential Revision: https://phabricator.services.mozilla.com/D106272 UltraBlame original commit: 3f23121524b1cee78069c8e0cc73a850ccd987c2
…. r=bdahl *Please note:* This will require mozilla/pdf.js#13014 landing first. Differential Revision: https://phabricator.services.mozilla.com/D106272 UltraBlame original commit: 3f23121524b1cee78069c8e0cc73a850ccd987c2
As can be seen in the mozilla-central code, we're already getting the Content-Disposition filename. However, that data isn't passed through to the viewer nor to the
PDFDataTransportStream-implementation, which explains why it's currently being ignored.Please note: This will also require a small mozilla-central patch, see https://bugzilla.mozilla.org/show_bug.cgi?id=1694556, to forward the necessary data to the viewer.
r? @brendandahl