Use Math.hypot, instead of Math.sqrt with manual squaring
#12973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
Math-hypot
branch
from
6926fb3 to
06c0b4b
Compare
When the PDF.js project started `Math.hypot` didn't exist yet, and until recently we still supported browsers (IE 11) without a native `Math.hypot` implementation; please see this compatibility information: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/hypot#browser_compatibility Furthermore, somewhat recently there were performance improvements of `Math.hypot` in Firefox; see https://bugzilla.mozilla.org/show_bug.cgi?id=1648820 Finally, this patch also replaces a couple of multiplications with the exponentiation operator.
Snuffleupagus
force-pushed
the
Math-hypot
branch
from
06c0b4b to
d212c40
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8073de2c1e52f70/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/8073de2c1e52f70/output.txt Total script time: 22.97 mins
Image differences available at: http://54.67.70.0:8877/8073de2c1e52f70/reftest-analyzer.html#web=eq.log |
|
/botio-windows test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://3.101.106.178:8877/9c1f2bc020715c0/output.txt |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/9c1f2bc020715c0/output.txt Total script time: 29.24 mins
Image differences available at: http://3.101.106.178:8877/9c1f2bc020715c0/reftest-analyzer.html#web=eq.log |
calixteman
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the PDF.js project started
Math.hypotdidn't exist yet, and until recently we still supported browsers (IE 11) without a nativeMath.hypotimplementation; please see this compatibility information: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/hypot#browser_compatibilityFurthermore, somewhat recently there were performance improvements of
Math.hypotin Firefox; see https://bugzilla.mozilla.org/show_bug.cgi?id=1648820Finally, this patch also replaces a couple of multiplications with the exponentiation operator.