Split PDFViewerApplication.error into two methods, for PDF document loading/parsing errors vs other errors (PR 11647 follow-up)
#12970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f339f54e72f3fbf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f339f54e72f3fbf/output.txt Total script time: 4.25 mins Published |
Snuffleupagus
force-pushed
the
viewer-error
branch
from
e047e5d to
0fb99ed
Compare
Snuffleupagus
commented
Feb 7, 2021
| @@ -812,6 +812,8 @@ const PDFViewerApplication = { | |||
| * destruction is completed. | |||
| */ | |||
| async close() { | |||
| this._unblockDocumentLoadEvent(); | |||
There was a problem hiding this comment.
While this really shouldn't matter for the Firefox built-in PDF Viewer use-case, since only the GENERIC viewer has openFile-support, in nonetheless can't hurt to ensure that closing a partially loaded document will actually fire the "load" event.
… loading/parsing errors vs other errors (PR 11647 follow-up) With these changes, we can easily unblock the "load" event regardless of where an error occurred.
Snuffleupagus
force-pushed
the
viewer-error
branch
from
0fb99ed to
2772723
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/01a1c7c4cb09387/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/01a1c7c4cb09387/output.txt Total script time: 4.26 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, we can easily unblock the "load" event regardless of where an error occurred.
/cc @emilio