Use optional chaining, where possible, in the web/-folder
#12961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…age labels internally, to make the `null` default value clearer Currently it's not *immediately* clear from the code itself, unless you look at the definition of `this._pageLabels`, that the default value is `null`.[1] We can improve this, and also reduce the amount of code, by using modern ECMAScript features such as optional chaining and nullish coalescing. --- [1] Keep in mind that an *empty* string is actually a valid page label, according to the PDF specification.
By using optional chaining, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining, it's possible to reduce unnecessary code-repetition in many cases.
Snuffleupagus
changed the title
web/-folder
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/ec1cbf2a7d622c5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/ec1cbf2a7d622c5/output.txt Total script time: 4.33 mins Published |
timvandermeij
approved these changes
Feb 6, 2021
|
Looks good; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slightly re-factor how the
BaseViewer/PDFThumbnailViewerhandle page labels internally, to make thenulldefault value clearerCurrently it's not immediately clear from the code itself, unless you look at the definition of
this._pageLabels, that the default value isnull.[1]We can improve this, and also reduce the amount of code, by using modern ECMAScript features such as optional chaining and nullish coalescing.
[1] Keep in mind that an empty string is actually a valid page label, according to the PDF specification.
Use optional chaining, where possible, in the
web/-folderBy using optional chaining, see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining, it's possible to reduce unnecessary code-repetition in many cases.