Don't focus the PasswordPrompt input-field on load, when the viewer is embedded in e.g. an iframe (issue 12951)
#12952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is embedded in e.g. an `iframe` (issue 12951) Given that we don't focus the viewer *itself* (among other things) when the viewer is embedded, I suppose that it makes some sense to not focus the `PasswordPrompt` input-field either on load. In order to improve the overall UX here, if an *incorrect* password was provided we'll still focus the input-field. Fixes 12951 (assuming we care to do so, of course).
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a70967730ac3c28/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a70967730ac3c28/output.txt Total script time: 4.21 mins Published |
timvandermeij
approved these changes
Feb 3, 2021
|
I agree that it makes sense, and it's a small change, so I'm fine with this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we don't focus the viewer itself (among other things) when the viewer is embedded, I suppose that it makes some sense to not focus the
PasswordPromptinput-field either on load.In order to improve the overall UX here, if an incorrect password was provided we'll still focus the input-field.
Fixes #12951 (assuming we care to do so, of course).