Ignore globally cached images in PartialEvaluator.getTextContent (PR 11930 follow-up)
#12922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…R 11930 follow-up) Given that we'll only cache `/XObject`s of the `Image`-type globally, we can utilize that in `PartialEvaluator.getTextContent` as well. This way, in cases such as e.g. issue 12098, we can avoid having to fetch/parse `/XObject`s that we already know to be `Image`s. This is helpful, since `Stream`s are not cached on the `XRef` instance (given their potential size) and the lookup can thus be somewhat expensive in general. Also, skip a redundant `RefSetCache.has` check in the `GlobalImageCache.getData` method.
Snuffleupagus
force-pushed
the
getTextContent-globalImageCache
branch
from
de4c448 to
72da2aa
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/6a4db0c597608c0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://3.101.106.178:8877/9dfb4167eb8b191/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/6a4db0c597608c0/output.txt Total script time: 26.83 mins
Image differences available at: http://54.67.70.0:8877/6a4db0c597608c0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/9dfb4167eb8b191/output.txt Total script time: 28.55 mins
Image differences available at: http://3.101.106.178:8877/9dfb4167eb8b191/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Jan 28, 2021
|
Good idea; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we'll only cache
/XObjects of theImage-type globally, we can utilize that inPartialEvaluator.getTextContentas well. This way, in cases such as e.g. issue #12098, we can avoid having to fetch/parse/XObjects that we already know to beImages. This is helpful, sinceStreams are not cached on theXRefinstance (given their potential size) and the lookup can thus be somewhat expensive in general.Also, skip a redundant
RefSetCache.hascheck in theGlobalImageCache.getDatamethod.