JS -- Fix events dispatchment and add tests #12569
Conversation
calixteman
commented
Nov 3, 2020
calixteman
commented
- dispatch event to take into account calculation order
- use a map for actions in Field
calixteman
force-pushed
the
events
branch
2 times, most recently
from
9833325 to
6498357
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/722bd9da4859af4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/240922577f6d7a2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/722bd9da4859af4/output.txt Total script time: 24.98 mins
Image differences available at: http://54.67.70.0:8877/722bd9da4859af4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/240922577f6d7a2/output.txt Total script time: 28.01 mins
Image differences available at: http://3.101.106.178:8877/240922577f6d7a2/reftest-analyzer.html#web=eq.log |
| return actionsMap; | ||
| } | ||
|
|
||
| _isButton() { |
There was a problem hiding this comment.
Is this going to be used more in the future? I only see this one return false; and one call to it.
There was a problem hiding this comment.
Yes especially for radio buttons.
| return target.obj._runActions(event); | ||
| } | ||
|
|
||
| calculateNow() { |
There was a problem hiding this comment.
* dispatch event to take into account calculation order * use a map for actions in Field
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://54.67.70.0:8877/94d245a9b370169/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://3.101.106.178:8877/032d7858e5bf4ca/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/94d245a9b370169/output.txt Total script time: 26.20 mins
Image differences available at: http://54.67.70.0:8877/94d245a9b370169/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://3.101.106.178:8877/032d7858e5bf4ca/output.txt Total script time: 28.69 mins
Image differences available at: http://3.101.106.178:8877/032d7858e5bf4ca/reftest-analyzer.html#web=eq.log |
