Skip to content

Fix some static analyzer warnings (issue 11965) #12561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Fix some static analyzer warnings (issue 11965) #12561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shared/fonts_utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ function readFontDictData(aString, aMap) {
var fontDictDataTokens = [];

var count = aString.length;
for (var i = 0; i < count; i) {
for (var i = 0; i < count; ) {
var value = aString[i++] | 0;
var token = null;

Expand Down
2 changes: 1 addition & 1 deletion web/chromecom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ class ChromeExternalServices extends DefaultExternalServices {
}

static createDownloadManager(options) {
return new DownloadManager(options);
return new DownloadManager();
}

static createPreferences() {
Expand Down
1 change: 0 additions & 1 deletion web/debugger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,6 @@ var Stepper = (function StepperClosure() {
line.appendChild(c("td", JSON.stringify(simplifyArgs(decArgs))));
}
if (operatorsToDisplay < operatorList.fnArray.length) {
line = c("tr");
var lastCell = c("td", "...");
lastCell.colspan = 4;
chunk.appendChild(lastCell);
Expand Down
2 changes: 1 addition & 1 deletion web/firefoxcom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ class FirefoxExternalServices extends DefaultExternalServices {
}

static createDownloadManager(options) {
return new DownloadManager(options);
return new DownloadManager();
}

static createPreferences() {
Expand Down
2 changes: 1 addition & 1 deletion web/genericcom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class GenericPreferences extends BasePreferences {

class GenericExternalServices extends DefaultExternalServices {
static createDownloadManager(options) {
return new DownloadManager(options);
return new DownloadManager();
}

static createPreferences() {
Expand Down