canvas: fix restore() with existing SMask groups and re-land #12363. #12369
Conversation
emilio
force-pushed
the
better-cancelation-follow-up
branch
from
6bd6b8f to
04b71f8
Compare
…stateStack is empty. This fixes the issue that caused mozilla#12363 to get reverted, see mozilla#12367. When we end the SMask group and stateStack.length is zero, nothing updates this.current to reflect it.
…Drawing. We were correctly finishing the SMask group but not restoring all the extra transformations applied in stateStack, so if somebody ends up drawing to the same context after canceling mid-draw we'd get artifacts. This re-lands mozilla#12363 and fixes Mozilla bug 1664178[1]. [1]: https://bugzilla.mozilla.org/show_bug.cgi?id=1664178
emilio
force-pushed
the
better-cancelation-follow-up
branch
from
04b71f8 to
bf8b1ad
Compare
emilio
changed the title
|
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/fe62fda808cffe1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 1 Live output at: http://54.67.70.0:8877/9ab00d5ad167ba3/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9ab00d5ad167ba3/output.txt Total script time: 27.33 mins
Image differences available at: http://54.67.70.0:8877/9ab00d5ad167ba3/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/fe62fda808cffe1/output.txt Total script time: 31.52 mins
Image differences available at: http://54.215.176.217:8877/fe62fda808cffe1/reftest-analyzer.html#web=eq.log |
|
Seems like the same kind of subpixel differences as in #12369. |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8c1865f0aa2753b/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8c1865f0aa2753b/output.txt Total script time: 3.50 mins Published |
|
Thank you! I have verified that the original issue that caused the backout is fixed now, and the code looks better like this. /botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/f0acda3c82600d3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/d63cb7eb8b8146f/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/d63cb7eb8b8146f/output.txt Total script time: 25.67 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/f0acda3c82600d3/output.txt Total script time: 30.26 mins
|
|
Np, thanks a lot for reviewing! |
This fixes #12367. When we end the SMask group and stateStack.length is zero,
nothing updates this.current to reflect it.