Remove CSS variables feature-testing from PDFSidebarResizer
#12352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9e4552d for causing the sidebar to become too narrow when the entire viewer is resized. **Steps to reproduce:** 1. Load the viewer. 2. Open the sidebar. 3. Resize the sidebar, making it wider. 4. Resize the entire viewer, i.e. the browser window, making it *narrower* than 400 pixels. **Expected result:** The sidebar width is clamped at 200 pixels. **Actual result:** The sidebar becomes too narrow. The cause of this bug is, in hindsight, quite obvious since the `clamp` helper function implicitly assumes that the `min`/`max` arguments are correctly sorted. At viewer widths *below* 400 pixels, that assumption is broken which explains the bug.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2c76ec3d2363866/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2c76ec3d2363866/output.txt Total script time: 3.47 mins Published |
CSS variables are now supported in all reasonably modern browsers, according to: - https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties#Browser_compatibility - https://caniuse.com/css-variables
Snuffleupagus
force-pushed
the
sidebar-resizer-CSS-vars
branch
from
b8c58c6 to
01c1d87
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/884bd83dc1d0ca3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/884bd83dc1d0ca3/output.txt Total script time: 3.46 mins Published |
timvandermeij
approved these changes
Sep 9, 2020
|
Nice to get rid of this code. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSS variables are now supported in all reasonably modern browsers, according to: