-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add (basic) support for transfer functions to Images (issue 6931, bug 1149713) #12219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (basic) support for transfer functions to Images (issue 6931, bug 1149713) #12219
Conversation
I completely overlooked the fact that `PartialEvaluator.handleSetFont` also updates the current `state`, which means that currently we're not actually handling font data correctly for cached /ExtGState data. (Thankfully, using /ExtGState to set a font is somewhat rare in practice.)
… 1149713) This is *similar* to the existing transfer function support for SMasks, but extended to simple image data. Please note that the extra amount of data now being sent to the worker-thread, for affected /ExtGState entries, is limited to *at most* 4 `Uint8Array`s each with a length of 256 elements. Refer to https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G9.1658137 for additional details.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/b03c2d8d19af9f2/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4518c81606f2e26/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/4518c81606f2e26/output.txt Total script time: 27.25 mins
Image differences available at: http://54.67.70.0:8877/4518c81606f2e26/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/b03c2d8d19af9f2/output.txt Total script time: 30.94 mins
Image differences available at: http://54.215.176.217:8877/b03c2d8d19af9f2/reftest-analyzer.html#web=eq.log |
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/26c6695ca190e44/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/26c6695ca190e44/output.txt Total script time: 3.28 mins Published |
Thank you for implementing this! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/00ac962882526d6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/398fcec06def77e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/00ac962882526d6/output.txt Total script time: 25.33 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/398fcec06def77e/output.txt Total script time: 27.21 mins
|
This is similar to the existing transfer function support for SMasks, but extended to simple image data.
Please note that the extra amount of data now being sent to the worker-thread, for affected /ExtGState entries, is limited to at most 4
Uint8Array
s each with a length of 256 elements.Refer to https://www.adobe.com/content/dam/acom/en/devnet/acrobat/pdfs/PDF32000_2008.pdf#G9.1658137 for additional details.
Fixes #6931
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1149713