bidi characters algorithm; separation of the toFontChar and toUnicode #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix comment in bidi
I fixed up some issues with bidi selection
|
There are some problems in CIDFontType0 toUnicode stuff @pdfjsbot test |
|
Processing command test by user notmasteryet. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/3975109.txt [bot:processed:3975109] |
ERROR(s) foundATTENTION: There was a snapshot difference: Output: Bot response time: 28.44 mins |
Conflicts: web/viewer.html
|
@pdfjsbot test |
|
Processing command test by user notmasteryet. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4059798.txt [bot:processed:4059798] |
ERROR(s) foundATTENTION: There was a snapshot difference: Output: Bot response time: 24.60 mins |
|
@pdfjsbot test |
|
Processing command test by user notmasteryet. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4061087.txt [bot:processed:4061087] |
ERROR(s) foundATTENTION: There was a snapshot difference: Output: Bot response time: 24.90 mins |
|
There are minor changes/movements in the chars on Ubuntu, but overall it's good. @arturadib, @brendandahl: i believe the code is ready for review and merge. |
Conflicts: src/fonts.js
|
@pdfjsbot test |
|
Processing command test by user notmasteryet. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4092879.txt [bot:processed:4092879] |
ERROR(s) foundATTENTION: There was a snapshot difference: Output: Bot response time: 24.76 mins |
|
@pdfjsbot test |
|
Processing command test by user notmasteryet. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4096344.txt [bot:processed:4096344] |
ERROR(s) foundATTENTION: There was a snapshot difference: Output: Bot response time: 24.61 mins |
| text.direction = 'ltr'; | ||
| return str; | ||
| } | ||
| else if (startLevel == -1) { |
There was a problem hiding this comment.
nit: move else if up a line
|
After the above are fixed, I'll review again and give my blessing. Biggest concern is all the new global scope functions introduced. |
|
hopefully got them all @pdfjsbot test |
|
Processing command test by user notmasteryet. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4127707.txt [bot:processed:4127707] |
ERROR(s) foundATTENTION: There was a snapshot difference: Output: Bot response time: 24.90 mins |
|
@pdfjsbot test |
|
Processing command test by user notmasteryet. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4128137.txt [bot:processed:4128137] |
ERROR(s) foundATTENTION: There was a snapshot difference: Output: Bot response time: 24.70 mins |
|
@pdfjsbot makeref |
|
Processing command makeref by user brendandahl. Queue size: 0 Live script output is available (after queueing is done) at: http://184.73.87.52:8989/4130618.txt [bot:processed:4130618] |
|
References generated Images pushed to Output: Bot response time: 27.90 mins |
arturadib
added a commit
that referenced
this pull request
Feb 23, 2012
bidi characters algorithm; separation of the toFontChar and toUnicode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.