[api-minor] Fix the annotationStorage parameter in PDFPageProxy.render
#12173
Conversation
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/20258da435200d9/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/e898d8f1c846afb/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/20258da435200d9/output.txt Total script time: 3.97 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/e898d8f1c846afb/output.txt Total script time: 4.99 mins
|
Snuffleupagus
force-pushed
the
render-annotationStorage
branch
2 times, most recently
from
8607756 to
3d588fb
Compare
…nder` While the parameter name (clearly) suggests that an `AnnotationStorage`-instance is expected, looking at the only call-sites that include the parameter (i.e. the `PDFPrintServiceFactory` instances) it actually contains just a normal Object. Hence it seems much more reasonable to actually pass a valid `AnnotationStorage`-instance, as the name suggests, and simply have `PDFPageProxy.render` do the `annotationStorage.getAll()` call. (Since we cannot send an `AnnotationStorage`-instance as-is to the worker-thread, given the "structured clone algorithm".)
…to accurately reflect `IPDFAnnotationLayerFactory` (PR 12147 follow-up)
Snuffleupagus
force-pushed
the
render-annotationStorage
branch
from
3d588fb to
a6c1ef8
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b1f6a0b4e4969f6/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/773b4bec94c356f/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b1f6a0b4e4969f6/output.txt Total script time: 3.86 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/773b4bec94c356f/output.txt Total script time: 4.89 mins
|
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/8ef8e99e96b34e4/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/8ef8e99e96b34e4/output.txt Total script time: 3.53 mins Published |
|
Thanks! |
While the parameter name (clearly) suggests that an
AnnotationStorage-instance is expected, looking at the only call-sites that include the parameter (i.e. thePDFPrintServiceFactoryinstances) it actually contains just a normal Object.Hence it seems much more reasonable to actually pass a valid
AnnotationStorage-instance, as the name suggests, and simply havePDFPageProxy.renderdo theannotationStorage.getAll()call. (Since we cannot send anAnnotationStorage-instance as-is to the worker-thread, given the "structured clone algorithm".)