Fix the gulp types task to run on Windows, and place the TypeScript definitions correctly in pdfjs-dist
#12168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You should change the diff --git a/gulpfile.js b/gulpfile.js
index 7da61ed1..6f3d480a 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -1640,7 +1640,7 @@ function packageBowerJson() {
name: DIST_NAME,
version: VERSION,
main: "build/pdf.js",
- types: "build/pdf.d.ts",
+ types: "types/pdf.d.ts",
description: DIST_DESCRIPTION,
keywords: DIST_KEYWORDS,
homepage: DIST_HOMEPAGE,See https://www.typescriptlang.org/docs/handbook/declaration-files/publishing.html |
Snuffleupagus
force-pushed
the
fix-types
branch
from
2d4a989 to
930e4e6
Compare
|
The following fixes diff --git a/gulpfile.js b/gulpfile.js
index e44d6e04..51b9921f 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -1374,7 +1374,7 @@ gulp.task(
.pipe(gulp.dest(TYPESTEST_DIR + "build/")),
gulp
.src(TYPES_BUILD_DIR + "**/**")
- .pipe(gulp.dest(TYPESTEST_DIR + "build/")),
+ .pipe(gulp.dest(TYPESTEST_DIR + "types/")),
]);
},
function (done) {I think |
Snuffleupagus
force-pushed
the
fix-types
branch
from
930e4e6 to
3965430
Compare
… definitions correctly in `pdfjs-dist` - Fix the `gulp types` task to run on Windows. Currently this fails, and the solution was to "borrow" the same formatting as used in the `gulp jsdoc` task. - Place the TypeScript definitions in their own `types` directory, when building `pdfjs-dist`. These should *not* be cluttering the main `build` directory, especially since the generated TypeScript definitions consists of *multiple folders*. (Only if the TypeScript definitions would be concatenated into *a single file*, would placing them directly in `pdfjs-dist/build` be acceptable.)
Snuffleupagus
force-pushed
the
fix-types
branch
from
3965430 to
fb85c2d
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/578d0e53c9437a2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/578d0e53c9437a2/output.txt Total script time: 3.49 mins Published |
timvandermeij
approved these changes
Aug 4, 2020
|
Tested locally as well and this seems to work just fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the
gulp typestask to run on Windows. Currently this fails, and the solution was to "borrow" the same formatting as used in thegulp jsdoctask.Place the TypeScript definitions in their own
typesdirectory, when buildingpdfjs-dist. These should not be cluttering the mainbuilddirectory, especially since the generated TypeScript definitions consists of multiple folders. (Only if the TypeScript definitions would be concatenated into a single file, would placing them directly inpdfjs-dist/buildbe acceptable.)