Ignore fetch() errors, in PDFFetchStreamRangeReader, once the request has been aborted
#12136
Conversation
…uest has been aborted Besides making general sense, as far as I can tell, this patch should also prevent *one* source of `Uncaught (in promise) ...` exceptions. Unfortunately `reason instanceof AbortError` doesn't work here, since `AbortError` isn't actually defined in browsers; note how even the DOM specification contains an example using the `name` property: https://dom.spec.whatwg.org/#aborting-ongoing-activities This patch prevents the following errors from being logged in the console, when the unit-tests are running: - Firefox: `Uncaught (in promise) DOMException: The operation was aborted.` - Chrome: `Uncaught (in promise) DOMException: The user aborted a request.`
|
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/f2c3bc01990a469/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/422b3686a8a08c6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/f2c3bc01990a469/output.txt Total script time: 3.84 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/422b3686a8a08c6/output.txt Total script time: 4.72 mins
|
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/b4145e316f86918/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/45d04f046450fb6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/b4145e316f86918/output.txt Total script time: 26.91 mins
Image differences available at: http://54.67.70.0:8877/b4145e316f86918/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/45d04f046450fb6/output.txt Total script time: 28.33 mins
Image differences available at: http://54.215.176.217:8877/45d04f046450fb6/reftest-analyzer.html#web=eq.log |
|
Thank you for looking into this! |
Besides making general sense, as far as I can tell, this patch should also prevent one source of
Uncaught (in promise) ...exceptions.Unfortunately
reason instanceof AbortErrordoesn't work here, sinceAbortErrorisn't actually defined in browsers; note how even the DOM specification contains an example using thenameproperty: https://dom.spec.whatwg.org/#aborting-ongoing-activitiesThis patch prevents the following errors from being logged in the console, when the unit-tests are running:
Uncaught (in promise) DOMException: The operation was aborted.Uncaught (in promise) DOMException: The user aborted a request.