Tweak the heuristic, in src/core/jpg.js, that handles JPEG images with a wildly incorrect SOF (Start of Frame) scanLines parameter (issue 10989)
#12063
Conversation
…ith a wildly incorrect SOF (Start of Frame) `scanLines` parameter (issue 10989)
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9b7a71f4c4c7157/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.215.176.217:8877/ef10ca9d2ad12af/output.txt |
| @@ -163,12 +163,16 @@ var JpegImage = (function JpegImageClosure() { | |||
| } else if (nextByte === /* EOI = */ 0xd9) { | |||
| if (parseDNLMarker) { | |||
| // NOTE: only 8-bit JPEG images are supported in this decoder. | |||
| const maybeScanLines = blockRow * 8; | |||
| const maybeScanLines = blockRow * (frame.precision === 8 ? 8 : 0); | |||
There was a problem hiding this comment.
Not completely related to the patch, but a better-safe-than-sorry sort of change when I had to touch related code anyway.
From: Bot.io (Linux m4)FailedFull output at http://54.67.70.0:8877/9b7a71f4c4c7157/output.txt Total script time: 26.72 mins
Image differences available at: http://54.67.70.0:8877/9b7a71f4c4c7157/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/ef10ca9d2ad12af/output.txt Total script time: 29.09 mins
Image differences available at: http://54.215.176.217:8877/ef10ca9d2ad12af/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9b8b269dec71bcd/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9b8b269dec71bcd/output.txt Total script time: 3.35 mins Published |
|
Nice find! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/a5485e61f9993e0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 1 Live output at: http://54.215.176.217:8877/0176ec4f43d59cf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/a5485e61f9993e0/output.txt Total script time: 24.83 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.215.176.217:8877/0176ec4f43d59cf/output.txt Total script time: 27.81 mins
|
Fixes #10989