Pattern not rendered #6297
Labels
Comments
brendandahl
added a commit
to brendandahl/pdf.js
that referenced
this issue
Jun 30, 2021
Previously, when we filled image masks we didn't copy over the current transformation, this caused patterns to be misaligned when painted. Now we create a temporary canvas with the mask and have the transform copied over and offset it relative to where the mask would be painted. We also weren't properly offsetting tiling patterns. This isn't usually noticeable since patters repeat, but in the case of mozilla#13561 the pattern is only drawn once and has to be in the correct position to line up with the mask image. These fixes broke mozilla#11473, but highlighted that we were drawing that correctly by accident and not correctly handling negative bounding boxes on tiling patterns. Fixes mozilla#6297, mozilla#13561, mozilla#13441, mozilla#13111 Partially fixes mozilla#1344 (still blurry but boxes are in correct position now)
brendandahl
added a commit
to brendandahl/pdf.js
that referenced
this issue
Jul 6, 2021
Previously, when we filled image masks we didn't copy over the current transformation, this caused patterns to be misaligned when painted. Now we create a temporary canvas with the mask and have the transform copied over and offset it relative to where the mask would be painted. We also weren't properly offsetting tiling patterns. This isn't usually noticeable since patters repeat, but in the case of mozilla#13561 the pattern is only drawn once and has to be in the correct position to line up with the mask image. These fixes broke mozilla#11473, but highlighted that we were drawing that correctly by accident and not correctly handling negative bounding boxes on tiling patterns. Fixes mozilla#6297, mozilla#13561, mozilla#13441, mozilla#13111 Partially fixes mozilla#1344 (still blurry but boxes are in correct position now)
brendandahl
added a commit
to brendandahl/pdf.js
that referenced
this issue
Jul 7, 2021
Previously, when we filled image masks we didn't copy over the current transformation, this caused patterns to be misaligned when painted. Now we create a temporary canvas with the mask and have the transform copied over and offset it relative to where the mask would be painted. We also weren't properly offsetting tiling patterns. This isn't usually noticeable since patters repeat, but in the case of mozilla#13561 the pattern is only drawn once and has to be in the correct position to line up with the mask image. These fixes broke mozilla#11473, but highlighted that we were drawing that correctly by accident and not correctly handling negative bounding boxes on tiling patterns. Fixes mozilla#6297, mozilla#13561, mozilla#13441 Partially fixes mozilla#1344 (still blurry but boxes are in correct position now)
bh213
pushed a commit
to bh213/pdf.js
that referenced
this issue
Jun 3, 2022
Previously, when we filled image masks we didn't copy over the current transformation, this caused patterns to be misaligned when painted. Now we create a temporary canvas with the mask and have the transform copied over and offset it relative to where the mask would be painted. We also weren't properly offsetting tiling patterns. This isn't usually noticeable since patters repeat, but in the case of mozilla#13561 the pattern is only drawn once and has to be in the correct position to line up with the mask image. These fixes broke mozilla#11473, but highlighted that we were drawing that correctly by accident and not correctly handling negative bounding boxes on tiling patterns. Fixes mozilla#6297, mozilla#13561, mozilla#13441 Partially fixes mozilla#1344 (still blurry but boxes are in correct position now)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://issues.apache.org/jira/secure/attachment/12744264/gs-bugzilla690297.pdf
Tiffany, Kelly and Doris (at the bottom) are not rendered. They are all in patterns, the other ladies (Paula, Denise and Neita) are not.
We at PDFBox do also have a problem with the same ladies, but a different one, see
https://issues.apache.org/jira/browse/PDFBOX-2864
See also
https://issues.apache.org/jira/browse/PDFBOX-1958
https://issues.apache.org/jira/secure/attachment/12632189/cinnebar.pdf
https://issues.apache.org/jira/secure/attachment/12631470/PATTYP2.pdf
The problem is to apply a stencil to a pattern color.
The text was updated successfully, but these errors were encountered: