Skip to content

Convert examples/components/simpleviewer.js to await/async #14128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendandahl opened this issue Oct 13, 2021 · 5 comments · Fixed by #14181
Closed

Convert examples/components/simpleviewer.js to await/async #14128

brendandahl opened this issue Oct 13, 2021 · 5 comments · Fixed by #14181

Comments

@brendandahl
Copy link
Contributor

Please do not work on this issue unless you have applied to the outreachy project.

The simpleviewer.js example currently uses the older style of promise.then and callbacks. Convert it to use an async function and await style.

@brendandahl brendandahl changed the title Convert examples/learning/helloworld.html to await/async Convert examples/components/simpleviewer.js to await/async Oct 13, 2021
@janekotovich
Copy link
Contributor

Hey I am Jane from Outreachy would love to work on this issue!

@marco-c
Copy link
Contributor

marco-c commented Oct 14, 2021

Since these "convert ..." issues are all similar to each other, please only work on one of them and let somebody else work on the others.

@ginjardev
Copy link

Hey I am Jane from Outreachy would love to work on this issue!

Jane, I see you have picked several issues. Please which one are you working on? I want to pick one but I see your trail all over the place.

@marco-c
Copy link
Contributor

marco-c commented Oct 14, 2021

@ginjardev you can take any open issue that doesn't have any PR linked to it.

@Alaa-Elghamry
Copy link

Hello! I'm an Outreachy applicant and I'd love to work on this bug. May I be assigned?

AnishaSingh0118 added a commit to AnishaSingh0118/pdf.js that referenced this issue Oct 24, 2021
issue resolved : mozilla#14128 
I have converted examples/components/simple viewer.js to await/async since it was using outdated style of promise.then and callbacks. 
So I converted it to use an async function and await style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants